Marc-Andre Lemburg <m...@egenix.com> added the comment: Antoine Pitrou wrote: > > Antoine Pitrou <pit...@free.fr> added the comment: > > Some comments: > - since there is already a weekday() method, the new method should be > called yearday() rather than yday() > - ditto for fromyday(): fromyearday() would be better > - Modules/datetimemodule.c should only be indented with tabs, but your > patch indents it with spaces in some places > - the algorithm in date_fromyday() looks suboptimal: if you repeatedly > call days_in_month(), you shouldn't have to call days_before_month() at > the end, you can compute it by yourself > > I haven't tested the patch yet. > > Marc-André, do you have any take on the principle of this?
mxDateTime uses attributes for such things, ie. .day_of_week, .day_of_year, .days_in_month. No idea, why the datetime module chose to implement access to this static information as method. I've never had a request for a way to construct a date by giving the year and day of the year - probably because it's just too easy to do by hand: 217 >>> Date(2009, 1, 1) + (217 - 1) <mx.DateTime.DateTime object for '2009-08-05 00:00:00.00' at 2b5320c262f0> ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue1436346> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
