Tarek Ziadé <ziade.ta...@gmail.com> added the comment:

> Two lines below already is another search for 'gcc' or 'g++', 
> which also should be changed from 'compiler[:3]' to 'compiler.find()'

But compiler[:3] implies that the compiler string starts *with* 'gcc'.

so are you sure we're looking for 'gcc' anywhere in the string,
or at the beginning of it ?

In any case, I find these string searches very weak in there. I am going
to  refactor a function in distutils that guesses the type of compiler,
given a list of known compilers 'names' and a list of matching strings
(or regular expressions) for them.

I'll take all cases from unixcompiler and add a test for that, then use
it in this code.

Please don't hesitate to give me your list of

compiler string -> compiler 'type'

so I can add them in my test.

Thanks !

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue6163>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to