Georg Brandl <ge...@python.org> added the comment: The patch leads to crashes with all the exceptions that have their own structs; since they are derived from BaseException they must start with the same binary layout as PyBaseExceptionObject (pointers to any exception will be cast to PyBaseExceptionObject).
This also shows one way in which this change can mess up third-party extensions (though I don't know if anybody does that): if some extension created new exception classes doing it the way we do, e.g. for SyntaxError. However, I have a different suggestion: we could put a user-set "message" in the __dict__. The getter would then check for that first and only warn if it falls back to self->message. See attached patch. ---------- Added file: http://bugs.python.org/file14901/exception-message-fix-2.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue6844> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
