Martin v. Löwis <mar...@v.loewis.de> added the comment:

Your patch looks right, although I have a few style issues:
- the if chaining looks complicated: we don't usually have an else when 
the if returns
- make sure you use tabs consistently with the rest of the file
- it may be better to use uid_t where appropriate, see issue6873

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue6508>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to