R. David Murray <rdmur...@bitdance.com> added the comment: I'll leave it to Vinay to pronounce on the request and the validity of the patch, but a couple of comments on the mechanics of the patch: You have some rogue whitespace on one of the blank lines. More importantly, you are adding a keyword parameter at the beginning of the list of keywords, which would change the semantics if someone passed in arguments positionally. Finally, you should check out PEP 8 about Python style...the line length should be less the 80, which means your docstring addition needs to be reformatted, as well as the __init__ line itself.
Thanks for contributing! Oh, and while I set the stage to test needed it doesn't look like there are any existing tests for SysLogHandler.... ---------- components: +Library (Lib) -Extension Modules nosy: +r.david.murray, vinay.sajip priority: -> normal stage: -> test needed type: behavior -> feature request versions: +Python 2.7, Python 3.2 -Python 2.6 _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue7086> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
