Brian Curtin <cur...@acm.org> added the comment:

Added the FlushViewOfFile calls, and an msync call to the close method. Not 
sure how to explicitly test this, if it's possible. Current tests pass on 
Windows, I'll need to check *NIX when I have the access later today.

As for justification, from the UnmapViewOfFile docs[1]: "To minimize the risk 
of data loss in the event of a power failure or a system crash, applications 
should explicitly flush modified pages using the FlushViewOfFile function."

[1] http://msdn.microsoft.com/en-us/library/aa366882%28VS.85%29.aspx

----------
keywords: +needs review, patch
nosy: +brian.curtin
priority:  -> normal
stage:  -> patch review
versions: +Python 2.7, Python 3.1, Python 3.2
Added file: http://bugs.python.org/file15838/issue2643.diff

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue2643>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to