Ezio Melotti <ezio.melo...@gmail.com> added the comment: In issue7092_test_support: 1) silence_py3k_warning should have a docstring that explain what the function does and what filters should be, possibly including an example; 2) I'd use "if not filters:" instead of "if filters == ():"; 3) are there cases where the third arg of filterwarnings is not DeprecationWarning? If not, it's probably better to turn "filters" in a list of regex instead than a sequence of tuples like (regex, DeprecationWarning); 4) maybe silence_py3k_warning could yield an instance of WarningsRecorder, in case someone wants to access the silenced warnings.
---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue7092> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
