New submission from R. David Murray <rdmur...@bitdance.com>:

While working on another shelve issue I noticed that the keyencoding keyword 
argument was added to shelf, but that the value is hardcoded to 'utf-8' in the 
__init__ body.  DbfilenameShelf does not have a keyencoding option, nor does 
open, but BsdDbShelf does.  It seems to me that keyencoding was intended to be 
exposed but the work was not completed.  However I could be wrong...in which 
case the module should probably just use sys.getdefaultencoding.

I've prepared a patch that fixes the hardcoding bug and adds docs for the 
places where the keyword argument is currently accepted.  If this argument is 
kept and is documented, it should presumably be added to DbfilenameShelf and 
open as well.

----------
assignee: georg.brandl
components: Documentation, Library (Lib)
files: shelve_keyencoding.patch
keywords: needs review, patch, patch
messages: 99193
nosy: georg.brandl, r.david.murray
priority: low
severity: normal
stage: patch review
status: open
title: Shelf 'keyencoding' keyword argument is undocumented and does not work.
versions: Python 3.1, Python 3.2
Added file: http://bugs.python.org/file16206/shelve_keyencoding.patch

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue7905>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to