Jean-Paul Calderone <exar...@divmod.com> added the comment:

Just a couple comments:

  * If MSG_WAITALL is defined and a signal interrupts recv, will a string 
shorter than requested will be returned by sock_recvall?
  * Since MSG_WAITALL is already exposed to Python (when the underlying 
platform provides it), I wonder if this could all be implemented more simply in 
pure Python.  Can you elaborate on the motivation to use C?

Someone should do another review when there are unit tests.

----------
nosy: +exarkun

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue1103213>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to