Antoine Pitrou <pit...@free.fr> added the comment: Some remarks: - I agree with RDM's comment regarding inheritance - you don't use use_poll in loop_waiting_for_flag() - calling time.sleep() in loop_waiting_for_flag() looks wrong to me - test_handle_error should check that the exception state is the expected one (ZeroDivisionError), if at all possible - in test_set_reuse_addr, if SO_REUSEADDR fails I would suggest skipping the test with self.skip(...), rather than passing silently - in test_set_reuse_addr, sock.close() rather than sock.close - does asyncore support IPv6? test_create_socket checks only AF_INET - do you plan to also test UDP? :)
---------- nosy: +pitrou _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue8490> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
