Yaniv Aknin <yaniv.ak...@gmail.com> added the comment:

I think if the test is conducted without closing stderr, it will only check 
that stdin/stdout are handled correctly (you could assume that if one handled 
stdin/stdout correctly, they did the same with stderr).

However, since I've used a context manager (_NoStandardFds) to handle the 
closing/restoration of the standard fds, I think the benefit (fuller test 
coverage) outweighs the cost (potentially harder debugging if there's a problem 
with the test); if I'm not mistaken, the context manager should restore your 
fds before the default exception handler writes to stdout (at least in the 
parent and the child prior to exec()).

n.b.: I've also created a Rietveld issue for this patch: 
http://codereview.appspot.com/1227041/show

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue6610>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to