Stefan Krah <stefan-use...@bytereef.org> added the comment:
Here's a patch with a test case. Without the fix in subprocess.py,
the test prints:
======================================================================
FAIL: test_specific_shell (__main__.POSIXProcessTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "Lib/test/test_subprocess.py", line 650, in test_specific_shell
self.assertEqual(p.stdout.read().strip(), sh)
AssertionError: '/bin/sh' != '/bin/bash'
I think trying bash and ksh is sufficient; "echo $0" works for both
(for csh it does not). David, does the patch look good?
Éric, I'm by no means a tracker expert, so I wonder why you set the
resolution to 'accepted' at such an early stage. Does 'accepted' mean
'This is a valid report.' or does it mean 'I think the patch is correct.'?
----------
keywords: +needs review
stage: unit test needed -> patch review
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9265>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
