Amaury Forgeot d'Arc <amaur...@gmail.com> added the comment:
The patch should be amended for python3, then:
- PyType_Ready() should be used instead of "ob_type = &PyType_Type;"
- The demo contains "Option choisie :" which should be translated :-)
- the call::
PyErr_SetString(PyExc_RuntimeError,
"remove_lom: can't find Menu Object");
is wrong: the calling function does not check the error condition, it will be
ignored in any case because the only called is the tp_dealloc
- find_po() is defined but never called
- the free() method does not do anything, it contains commented out code.
In short, this patch needs work.
----------
nosy: +amaury.forgeotdarc
stage: unit test needed -> needs patch
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue1723038>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
