Fred L. Drake, Jr. <fdr...@acm.org> added the comment:
- Using _UNSET & similar in the docs is not good; there used to be a
way to note a parameter as optional. Not sure whether there is any
more.
- Docs for methods which take vars/default should include a note
indicating where to find the explanation, since reference docs are
often read in a non-linear manner.
- This is a tortured way to only do something in a particular condition:
value = str(value) if value is not None else None
These two lines are actually more readable, since it's clear that
the branch is a no-op:
if value is not None:
value = str(value)
- _unify_boolean is a strange name; doesn't parallel _unify_values at
all.
- Having _COMPATIBLE and _UNSET defined in the classes looks more
painful than not; no need to change for this patch. (Should be
changed in some later cleanup.) Moving the whole _unify_boolean /
_boolean_states mess to a separate top-level function that can be
used for the conversion is attractive.
----------
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9421>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
