Amaury Forgeot d'Arc <amaur...@gmail.com> added the comment: The calls to Py_GetFinalPathNameByHandle come in pairs: one to get the length, the other to retrieve the value. They should at least be consistent. There are two other issues:
- in all three places, it's possible for the function to return after malloc(), but before the call to free(); and PyMem_Malloc()/PyMem_Free() would be better. - on my windows XP, os.stat() is slower than before, and is now significantly slower than os.lstat() (26.6 usec -> 32.8 usec); I found that check_GetFinalPathNameByHandle() repeatedly checks for the presence of the function, and always calls GetModuleHandle() and GetProcAddress(). The attached patch fixes this, can you test it on Vista? ---------- Added file: http://bugs.python.org/file18550/faster_stat.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue9445> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
