STINNER Victor <victor.stin...@haypocalc.com> added the comment: test_pipe_cloexec_unix_tools() is specific to UNIX/BSD because it requires cat and grep programs. You should try to reuse the Python interpreter to have a portable test (eg. working on Windows), as you did with fd_status.py.
+ data = b'aaaaaaaaaaaaaaaaaaaa\n' + subdata = b'aaa' + assert subdata in data, "Test broken" Use maybe subdata = data[:3] to avoid an assertion. I don't understand why do you talk about "atomicity". Do you test add non-atomic operations? Was subprocess atomic? If I understood correctly, you are fixing a specific issue which can be called something like "subprocess: close pipes on exec(), set FD_CLOEXEC flag to all pipes", and no more changing the default value of close_fds. Can you update the title please? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue7213> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
