New submission from Éric Araujo <mer...@netwok.org>: Some comments. Haven’t tested the patch yet.
http://codereview.appspot.com/4090042/diff/1/Lib/pydoc.py File Lib/pydoc.py (right): http://codereview.appspot.com/4090042/diff/1/Lib/pydoc.py#newcode2507 Lib/pydoc.py:2507: <div style='overflow:auto'> Does this work fine with common Web browsers, including not-most-recent versions, and various resolutions? (“fine” being defined as “not worse than before the patch”) http://codereview.appspot.com/4090042/diff/1/Lib/pydoc.py#newcode2591 Lib/pydoc.py:2591: return '<a href="topic?key=%s.html">%s</a>' % (name, name) I see no reason for polluting the key value with “.html” http://codereview.appspot.com/4090042/diff/1/Lib/pydoc.py#newcode2713 Lib/pydoc.py:2713: raise TypeError('unknown content type %r' % ([url, content_type])) You can remove the extraneous parens around the list. http://codereview.appspot.com/4090042/diff/1/Lib/test/test_pydoc.py File Lib/test/test_pydoc.py (right): http://codereview.appspot.com/4090042/diff/1/Lib/test/test_pydoc.py#newcode431 Lib/test/test_pydoc.py:431: ("", "PyDoc: Index of Modules"), I’m not sure “PyDoc” is better than “Python”. What about “Python Doc”? Very clear and still short. http://codereview.appspot.com/4090042/ ---------- messages: 126765 nosy: eric.araujo priority: normal severity: normal status: open title: #10961: Pydoc touchups in new 3.2 Web server (issue4090042) _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue10975> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
