https://github.com/python/cpython/commit/e45bae7a45e5696c3ebdf477ecc948374cf8ebff
commit: e45bae7a45e5696c3ebdf477ecc948374cf8ebff
branch: main
author: Michael Droettboom <[email protected]>
committer: brandtbucher <[email protected]>
date: 2024-01-22T11:45:15-08:00
summary:
GH-114448: Don't sort summarize_stats.py histograms by amount of change
(GH-114449)
files:
M Tools/scripts/summarize_stats.py
diff --git a/Tools/scripts/summarize_stats.py b/Tools/scripts/summarize_stats.py
index df8a7fddfb8866..1e9dc07bae8981 100644
--- a/Tools/scripts/summarize_stats.py
+++ b/Tools/scripts/summarize_stats.py
@@ -460,8 +460,11 @@ class JoinMode(enum.Enum):
# second column of each input table as a new column
CHANGE = 1
# Join using the first column as a key, indicating the change in the second
- # column of each input table as a ne column, and omit all other columns
+ # column of each input table as a new column, and omit all other columns
CHANGE_ONE_COLUMN = 2
+ # Join using the first column as a key, and indicate the change as a new
+ # column, but don't sort by the amount of change.
+ CHANGE_NO_SORT = 3
class Table:
@@ -484,7 +487,7 @@ def join_row(self, key: str, row_a: tuple, row_b: tuple) ->
tuple:
match self.join_mode:
case JoinMode.SIMPLE:
return (key, *row_a, *row_b)
- case JoinMode.CHANGE:
+ case JoinMode.CHANGE | JoinMode.CHANGE_NO_SORT:
return (key, *row_a, *row_b, DiffRatio(row_a[0], row_b[0]))
case JoinMode.CHANGE_ONE_COLUMN:
return (key, row_a[0], row_b[0], DiffRatio(row_a[0], row_b[0]))
@@ -497,7 +500,7 @@ def join_columns(self, columns: Columns) -> Columns:
*("Base " + x for x in columns[1:]),
*("Head " + x for x in columns[1:]),
)
- case JoinMode.CHANGE:
+ case JoinMode.CHANGE | JoinMode.CHANGE_NO_SORT:
return (
columns[0],
*("Base " + x for x in columns[1:]),
@@ -1027,7 +1030,7 @@ def iter_optimization_tables(base_stats: Stats,
head_stats: Stats | None = None)
Table(
("Range", "Count:", "Ratio:"),
calc_histogram_table(name, den),
- JoinMode.CHANGE,
+ JoinMode.CHANGE_NO_SORT,
)
],
)
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]