https://github.com/python/cpython/commit/665b8f365efc4e0063f764e20d3cad13635232f3
commit: 665b8f365efc4e0063f764e20d3cad13635232f3
branch: main
author: Steve Dower <[email protected]>
committer: zooba <[email protected]>
date: 2024-01-22T21:19:16Z
summary:
gh-113655: Revert extra stack reserve in PGO builds unless
UseExtraStackReserve=true (GH-114263)
files:
M PCbuild/python.vcxproj
M PCbuild/pythonw.vcxproj
diff --git a/PCbuild/python.vcxproj b/PCbuild/python.vcxproj
index 1e5ab877488e4a..4a99ffc677c287 100644
--- a/PCbuild/python.vcxproj
+++ b/PCbuild/python.vcxproj
@@ -99,7 +99,7 @@
<StackReserveSize Condition="$(Configuration) ==
'Debug'">12000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) ==
'PGInstrument'">12000000</StackReserveSize>
<!-- HACK: Need additional memory to avoid crashing until gh-113655 is
fixed -->
- <StackReserveSize Condition="$(Configuration) ==
'PGUpdate'">3000000</StackReserveSize>
+ <StackReserveSize Condition="$(Configuration) == 'PGUpdate' and
$(UseExtraStackReserve) == 'true'">3000000</StackReserveSize>
</Link>
</ItemDefinitionGroup>
<ItemGroup>
diff --git a/PCbuild/pythonw.vcxproj b/PCbuild/pythonw.vcxproj
index d6cf0c97dedb09..d08c210ef8a1dc 100644
--- a/PCbuild/pythonw.vcxproj
+++ b/PCbuild/pythonw.vcxproj
@@ -94,7 +94,7 @@
<StackReserveSize Condition="$(Configuration) ==
'Debug'">12000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) ==
'PGInstrument'">12000000</StackReserveSize>
<!-- HACK: Need additional memory to avoid crashing until gh-113655 is
fixed -->
- <StackReserveSize Condition="$(Configuration) ==
'PGUpdate'">3000000</StackReserveSize>
+ <StackReserveSize Condition="$(Configuration) == 'PGUpdate' and
$(UseExtraStackReserve) == 'true'">3000000</StackReserveSize>
</Link>
</ItemDefinitionGroup>
<ItemGroup>
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
