https://github.com/python/cpython/commit/efc489021c2a5dba46979bd304563aee0c479a31
commit: efc489021c2a5dba46979bd304563aee0c479a31
branch: main
author: Jason Zhang <[email protected]>
committer: serhiy-storchaka <[email protected]>
date: 2024-02-03T17:11:10+02:00
summary:

gh-111417: Remove unused code block in math.trunc() and round() (GH-111454)

_PyObject_LookupSpecial() now ensures that the type is ready.

files:
M Modules/mathmodule.c
M Python/bltinmodule.c

diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c
index 0be46b1574c1fe..a877bfcd6afb68 100644
--- a/Modules/mathmodule.c
+++ b/Modules/mathmodule.c
@@ -2074,11 +2074,6 @@ math_trunc(PyObject *module, PyObject *x)
         return PyFloat_Type.tp_as_number->nb_int(x);
     }
 
-    if (!_PyType_IsReady(Py_TYPE(x))) {
-        if (PyType_Ready(Py_TYPE(x)) < 0)
-            return NULL;
-    }
-
     math_module_state *state = get_math_module_state(module);
     trunc = _PyObject_LookupSpecial(x, state->str___trunc__);
     if (trunc == NULL) {
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
index e54d5cbacdc96f..31c1bf07e8fb91 100644
--- a/Python/bltinmodule.c
+++ b/Python/bltinmodule.c
@@ -2382,11 +2382,6 @@ builtin_round_impl(PyObject *module, PyObject *number, 
PyObject *ndigits)
 {
     PyObject *round, *result;
 
-    if (!_PyType_IsReady(Py_TYPE(number))) {
-        if (PyType_Ready(Py_TYPE(number)) < 0)
-            return NULL;
-    }
-
     round = _PyObject_LookupSpecial(number, &_Py_ID(__round__));
     if (round == NULL) {
         if (!PyErr_Occurred())

_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]

Reply via email to