https://github.com/python/cpython/commit/4aa4f0906df9fc9c6c6f6657f2c521468c6b1688
commit: 4aa4f0906df9fc9c6c6f6657f2c521468c6b1688
branch: main
author: Serhiy Storchaka <[email protected]>
committer: serhiy-storchaka <[email protected]>
date: 2024-02-05T22:42:43+02:00
summary:
gh-109475: Fix support of explicit option value "--" in argparse (GH-114814)
For example "--option=--".
files:
A Misc/NEWS.d/next/Library/2024-01-31-20-07-11.gh-issue-109475.lmTb9S.rst
M Lib/argparse.py
M Lib/test/test_argparse.py
diff --git a/Lib/argparse.py b/Lib/argparse.py
index 9e19f39fadd87b..2131d729746d41 100644
--- a/Lib/argparse.py
+++ b/Lib/argparse.py
@@ -2485,7 +2485,7 @@ def parse_known_intermixed_args(self, args=None,
namespace=None):
# ========================
def _get_values(self, action, arg_strings):
# for everything but PARSER, REMAINDER args, strip out first '--'
- if action.nargs not in [PARSER, REMAINDER]:
+ if not action.option_strings and action.nargs not in [PARSER,
REMAINDER]:
try:
arg_strings.remove('--')
except ValueError:
diff --git a/Lib/test/test_argparse.py b/Lib/test/test_argparse.py
index 940d7e95f96e20..d1f3d40000140d 100644
--- a/Lib/test/test_argparse.py
+++ b/Lib/test/test_argparse.py
@@ -5405,6 +5405,22 @@ def test_zero_or_more_optional(self):
args = parser.parse_args([])
self.assertEqual(NS(x=[]), args)
+ def test_double_dash(self):
+ parser = argparse.ArgumentParser()
+ parser.add_argument('-f', '--foo', nargs='*')
+ parser.add_argument('bar', nargs='*')
+
+ args = parser.parse_args(['--foo=--'])
+ self.assertEqual(NS(foo=['--'], bar=[]), args)
+ args = parser.parse_args(['--foo', '--'])
+ self.assertEqual(NS(foo=[], bar=[]), args)
+ args = parser.parse_args(['-f--'])
+ self.assertEqual(NS(foo=['--'], bar=[]), args)
+ args = parser.parse_args(['-f', '--'])
+ self.assertEqual(NS(foo=[], bar=[]), args)
+ args = parser.parse_args(['--foo', 'a', 'b', '--', 'c', 'd'])
+ self.assertEqual(NS(foo=['a', 'b'], bar=['c', 'd']), args)
+
# ===========================
# parse_intermixed_args tests
diff --git
a/Misc/NEWS.d/next/Library/2024-01-31-20-07-11.gh-issue-109475.lmTb9S.rst
b/Misc/NEWS.d/next/Library/2024-01-31-20-07-11.gh-issue-109475.lmTb9S.rst
new file mode 100644
index 00000000000000..7582cb2bcd7629
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2024-01-31-20-07-11.gh-issue-109475.lmTb9S.rst
@@ -0,0 +1,2 @@
+Fix support of explicit option value "--" in :mod:`argparse` (e.g.
+``--option=--``).
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
