https://github.com/python/cpython/commit/75935746be0cbd32b9d710b93db9bd49c8d634ba
commit: 75935746be0cbd32b9d710b93db9bd49c8d634ba
branch: main
author: et-repositories <[email protected]>
committer: carljm <[email protected]>
date: 2024-03-19T08:58:40-06:00
summary:
gh-116647: Fix recursive child in dataclasses (#116790)
files:
A Misc/NEWS.d/next/Library/2024-03-14-09-38-51.gh-issue-116647.h0d_zj.rst
M Lib/dataclasses.py
M Lib/test/test_dataclasses/__init__.py
diff --git a/Lib/dataclasses.py b/Lib/dataclasses.py
index e511eff4125038..7db8a4233df883 100644
--- a/Lib/dataclasses.py
+++ b/Lib/dataclasses.py
@@ -1075,7 +1075,9 @@ def _process_class(cls, init, repr, eq, order,
unsafe_hash, frozen,
cmp_fields = (field for field in field_list if field.compare)
terms = [f'self.{field.name}==other.{field.name}' for field in
cmp_fields]
field_comparisons = ' and '.join(terms) or 'True'
- body = [f'if other.__class__ is self.__class__:',
+ body = [f'if self is other:',
+ f' return True',
+ f'if other.__class__ is self.__class__:',
f' return {field_comparisons}',
f'return NotImplemented']
func = _create_fn('__eq__',
diff --git a/Lib/test/test_dataclasses/__init__.py
b/Lib/test/test_dataclasses/__init__.py
index e27abac5111394..832e5672c77d0d 100644
--- a/Lib/test/test_dataclasses/__init__.py
+++ b/Lib/test/test_dataclasses/__init__.py
@@ -2471,6 +2471,15 @@ def __repr__(self):
class TestEq(unittest.TestCase):
+ def test_recursive_eq(self):
+ # Test a class with recursive child
+ @dataclass
+ class C:
+ recursive: object = ...
+ c = C()
+ c.recursive = c
+ self.assertEqual(c, c)
+
def test_no_eq(self):
# Test a class with no __eq__ and eq=False.
@dataclass(eq=False)
diff --git
a/Misc/NEWS.d/next/Library/2024-03-14-09-38-51.gh-issue-116647.h0d_zj.rst
b/Misc/NEWS.d/next/Library/2024-03-14-09-38-51.gh-issue-116647.h0d_zj.rst
new file mode 100644
index 00000000000000..081f36bff91633
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2024-03-14-09-38-51.gh-issue-116647.h0d_zj.rst
@@ -0,0 +1 @@
+Fix recursive child in dataclasses
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
