https://github.com/python/cpython/commit/397d88db5e9ab2a43de3fdf5f8b973a949edc405
commit: 397d88db5e9ab2a43de3fdf5f8b973a949edc405
branch: main
author: Sam Gross <[email protected]>
committer: colesbury <[email protected]>
date: 2024-03-29T13:34:04-04:00
summary:
gh-117344: Skip flaky tests in free-threaded build (#117355)
The tests are not reliable with the GIL disabled. In theory, they can
fail with the GIL enabled too, but the failures are much more likely
with the GIL disabled.
files:
M Lib/test/test_concurrent_futures/test_process_pool.py
M Lib/test/test_concurrent_futures/test_thread_pool.py
diff --git a/Lib/test/test_concurrent_futures/test_process_pool.py
b/Lib/test/test_concurrent_futures/test_process_pool.py
index 70444bb147fadc..e60e7a6607a997 100644
--- a/Lib/test/test_concurrent_futures/test_process_pool.py
+++ b/Lib/test/test_concurrent_futures/test_process_pool.py
@@ -116,6 +116,7 @@ def test_saturation(self):
for _ in range(job_count):
sem.release()
+ @unittest.skipIf(support.Py_GIL_DISABLED, "gh-117344: test is flaky
without the GIL")
def test_idle_process_reuse_one(self):
executor = self.executor
assert executor._max_workers >= 4
diff --git a/Lib/test/test_concurrent_futures/test_thread_pool.py
b/Lib/test/test_concurrent_futures/test_thread_pool.py
index 16043fd1235614..86e65265516c3f 100644
--- a/Lib/test/test_concurrent_futures/test_thread_pool.py
+++ b/Lib/test/test_concurrent_futures/test_thread_pool.py
@@ -41,6 +41,7 @@ def acquire_lock(lock):
sem.release()
executor.shutdown(wait=True)
+ @unittest.skipIf(support.Py_GIL_DISABLED, "gh-117344: test is flaky
without the GIL")
def test_idle_thread_reuse(self):
executor = self.executor_type()
executor.submit(mul, 21, 2).result()
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
