https://github.com/python/cpython/commit/eca377f203c95153f69faf7d435f5e537ad9b59a commit: eca377f203c95153f69faf7d435f5e537ad9b59a branch: 3.12 author: Miss Islington (bot) <[email protected]> committer: zooba <[email protected]> date: 2024-04-03T22:32:09Z summary:
gh-117267: Ensure DirEntry.stat().st_ctime still contains creation time during deprecation period (GH-117354) (cherry picked from commit 985917dc8d34e2d2f717f7a981580a8dcf18d53a) Co-authored-by: Steve Dower <[email protected]> files: A Misc/NEWS.d/next/Windows/2024-03-28-22-12-00.gh-issue-117267.K_tki1.rst M Modules/posixmodule.c diff --git a/Misc/NEWS.d/next/Windows/2024-03-28-22-12-00.gh-issue-117267.K_tki1.rst b/Misc/NEWS.d/next/Windows/2024-03-28-22-12-00.gh-issue-117267.K_tki1.rst new file mode 100644 index 00000000000000..d3221429850a11 --- /dev/null +++ b/Misc/NEWS.d/next/Windows/2024-03-28-22-12-00.gh-issue-117267.K_tki1.rst @@ -0,0 +1,5 @@ +Ensure ``DirEntry.stat().st_ctime`` behaves consistently with +:func:`os.stat` during the deprecation period of ``st_ctime`` by containing +the same value as ``st_birthtime``. After the deprecation period, +``st_ctime`` will be the metadata change time (or unavailable through +``DirEntry``), and only ``st_birthtime`` will contain the creation time. diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index 9f69c792614eec..8fce40bb686783 100644 --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -15050,6 +15050,10 @@ DirEntry_from_find_data(PyObject *module, path_t *path, WIN32_FIND_DATAW *dataW) find_data_to_file_info(dataW, &file_info, &reparse_tag); _Py_attribute_data_to_stat(&file_info, reparse_tag, NULL, NULL, &entry->win32_lstat); + /* ctime is only deprecated from 3.12, so we copy birthtime across */ + entry->win32_lstat.st_ctime = entry->win32_lstat.st_birthtime; + entry->win32_lstat.st_ctime_nsec = entry->win32_lstat.st_birthtime_nsec; + return (PyObject *)entry; error: _______________________________________________ Python-checkins mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-checkins.python.org/ Member address: [email protected]
