https://github.com/python/cpython/commit/11f8348d78c22f85694d7a424541b34d6054a8ee
commit: 11f8348d78c22f85694d7a424541b34d6054a8ee
branch: main
author: Serhiy Storchaka <[email protected]>
committer: serhiy-storchaka <[email protected]>
date: 2024-04-30T15:04:16+03:00
summary:
gh-118404: Fix inspect.signature() for non-comparable callables (GH-118405)
files:
A Misc/NEWS.d/next/Library/2024-04-29-22-11-54.gh-issue-118404.GYfMaD.rst
M Lib/inspect.py
M Lib/test/test_inspect/test_inspect.py
diff --git a/Lib/inspect.py b/Lib/inspect.py
index 1f4216f0389d28..d46514f4b10467 100644
--- a/Lib/inspect.py
+++ b/Lib/inspect.py
@@ -2179,8 +2179,10 @@ def _signature_is_builtin(obj):
ismethoddescriptor(obj) or
isinstance(obj, _NonUserDefinedCallables) or
# Can't test 'isinstance(type)' here, as it would
- # also be True for regular python classes
- obj in (type, object))
+ # also be True for regular python classes.
+ # Can't use the `in` operator here, as it would
+ # invoke the custom __eq__ method.
+ obj is type or obj is object)
def _signature_is_functionlike(obj):
diff --git a/Lib/test/test_inspect/test_inspect.py
b/Lib/test/test_inspect/test_inspect.py
index 6b577090bdff68..fbef34eddacb3a 100644
--- a/Lib/test/test_inspect/test_inspect.py
+++ b/Lib/test/test_inspect/test_inspect.py
@@ -4690,6 +4690,16 @@ class D2(D1):
self.assertEqual(inspect.signature(D2), inspect.signature(D1))
+ def test_signature_on_non_comparable(self):
+ class NoncomparableCallable:
+ def __call__(self, a):
+ pass
+ def __eq__(self, other):
+ 1/0
+ self.assertEqual(self.signature(NoncomparableCallable()),
+ ((('a', ..., ..., 'positional_or_keyword'),),
+ ...))
+
class TestParameterObject(unittest.TestCase):
def test_signature_parameter_kinds(self):
diff --git
a/Misc/NEWS.d/next/Library/2024-04-29-22-11-54.gh-issue-118404.GYfMaD.rst
b/Misc/NEWS.d/next/Library/2024-04-29-22-11-54.gh-issue-118404.GYfMaD.rst
new file mode 100644
index 00000000000000..b8f9ee061ac164
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2024-04-29-22-11-54.gh-issue-118404.GYfMaD.rst
@@ -0,0 +1 @@
+Fix :func:`inspect.signature` for non-comparable callables.
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
