https://github.com/python/cpython/commit/d419d468ff4aaf6bc673354d0ee41b273d09dd3f
commit: d419d468ff4aaf6bc673354d0ee41b273d09dd3f
branch: main
author: Sam Gross <[email protected]>
committer: colesbury <[email protected]>
date: 2024-06-04T17:38:29Z
summary:
gh-120039: Reduce expected timeout in test_siginterrupt_off (#120047)
The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
files:
M Lib/test/test_signal.py
diff --git a/Lib/test/test_signal.py b/Lib/test/test_signal.py
index 61fb047caf6dab..591cd4177d9f41 100644
--- a/Lib/test/test_signal.py
+++ b/Lib/test/test_signal.py
@@ -698,7 +698,7 @@ def handler(signum, frame):
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
class SiginterruptTest(unittest.TestCase):
- def readpipe_interrupted(self, interrupt):
+ def readpipe_interrupted(self, interrupt, timeout=support.SHORT_TIMEOUT):
"""Perform a read during which a signal will arrive. Return True if
the
read is interrupted by the signal and raises an exception. Return
False
if it returns normally.
@@ -746,7 +746,7 @@ def handler(signum, frame):
# wait until the child process is loaded and has started
first_line = process.stdout.readline()
- stdout, stderr =
process.communicate(timeout=support.SHORT_TIMEOUT)
+ stdout, stderr = process.communicate(timeout=timeout)
except subprocess.TimeoutExpired:
process.kill()
return False
@@ -777,7 +777,7 @@ def test_siginterrupt_off(self):
# If a signal handler is installed and siginterrupt is called with
# a false value for the second argument, when that signal arrives, it
# does not interrupt a syscall that's in progress.
- interrupted = self.readpipe_interrupted(False)
+ interrupted = self.readpipe_interrupted(False, timeout=2)
self.assertFalse(interrupted)
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
