https://github.com/python/cpython/commit/78634cfa3dd4b542897835d5f097604dbeb0f3fd
commit: 78634cfa3dd4b542897835d5f097604dbeb0f3fd
branch: main
author: Victor Stinner <[email protected]>
committer: vstinner <[email protected]>
date: 2024-06-06T17:31:33+02:00
summary:
gh-120155: Initialize variables in _tkinter.c (#120156)
Initialize variables in _tkinter.c to make static analyzers happy.
files:
M Modules/_tkinter.c
diff --git a/Modules/_tkinter.c b/Modules/_tkinter.c
index 24f87c8d34c6b2..a34646aecb3ec8 100644
--- a/Modules/_tkinter.c
+++ b/Modules/_tkinter.c
@@ -1438,7 +1438,7 @@ Tkapp_Call(PyObject *selfptr, PyObject *args)
marshal the parameters to the interpreter thread. */
Tkapp_CallEvent *ev;
Tcl_Condition cond = NULL;
- PyObject *exc;
+ PyObject *exc = NULL; // init to make static analyzers happy
if (!WaitForMainloop(self))
return NULL;
ev = (Tkapp_CallEvent*)attemptckalloc(sizeof(Tkapp_CallEvent));
@@ -1712,7 +1712,8 @@ var_invoke(EventFunc func, PyObject *selfptr, PyObject
*args, int flags)
TkappObject *self = (TkappObject*)selfptr;
if (self->threaded && self->thread_id != Tcl_GetCurrentThread()) {
VarEvent *ev;
- PyObject *res, *exc;
+ // init 'res' and 'exc' to make static analyzers happy
+ PyObject *res = NULL, *exc = NULL;
Tcl_Condition cond = NULL;
/* The current thread is not the interpreter thread. Marshal
@@ -2413,6 +2414,8 @@ _tkinter_tkapp_createcommand_impl(TkappObject *self,
const char *name,
data->self = self;
data->func = Py_NewRef(func);
if (self->threaded && self->thread_id != Tcl_GetCurrentThread()) {
+ err = 0; // init to make static analyzers happy
+
Tcl_Condition cond = NULL;
CommandEvent *ev = (CommandEvent*)attemptckalloc(sizeof(CommandEvent));
if (ev == NULL) {
@@ -2468,6 +2471,8 @@ _tkinter_tkapp_deletecommand_impl(TkappObject *self,
const char *name)
TRACE(self, ("((sss))", "rename", name, ""));
if (self->threaded && self->thread_id != Tcl_GetCurrentThread()) {
+ err = 0; // init to make static analyzers happy
+
Tcl_Condition cond = NULL;
CommandEvent *ev;
ev = (CommandEvent*)attemptckalloc(sizeof(CommandEvent));
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
