https://github.com/python/cpython/commit/e6076d1e1303c3cc14bc02baf607535af2cf1501
commit: e6076d1e1303c3cc14bc02baf607535af2cf1501
branch: main
author: Eric Snow <[email protected]>
committer: ericsnowcurrently <[email protected]>
date: 2024-06-07T11:44:56-06:00
summary:

gh-119659: Get the datetime CAPI Tests Running Again (gh-120180)

The tests were accidentally disabled by 2da0dc0, which didn't handle classes 
correctly.

I considered updating no_rerun() to support classes, but the way 
test_datetime.py works would have made things fairly messy.  Plus, it looks 
like the refleaks we had encountered before have been resolved.

files:
M Lib/test/datetimetester.py
M Lib/test/support/__init__.py

diff --git a/Lib/test/datetimetester.py b/Lib/test/datetimetester.py
index 3759504b02e550..b80da5697ef865 100644
--- a/Lib/test/datetimetester.py
+++ b/Lib/test/datetimetester.py
@@ -22,7 +22,7 @@
 
 from test import support
 from test.support import is_resource_enabled, ALWAYS_EQ, LARGEST, SMALLEST
-from test.support import warnings_helper, no_rerun
+from test.support import warnings_helper
 
 import datetime as datetime_module
 from datetime import MINYEAR, MAXYEAR
@@ -6385,7 +6385,6 @@ class IranTest(ZoneInfoTest):
 
 
 @unittest.skipIf(_testcapi is None, 'need _testcapi module')
-@no_rerun("the encapsulated datetime C API does not support reloading")
 class CapiTest(unittest.TestCase):
     def setUp(self):
         # Since the C API is not present in the _Pure tests, skip all tests
diff --git a/Lib/test/support/__init__.py b/Lib/test/support/__init__.py
index 4b320b494bb8dd..9e6100d2b89d6e 100644
--- a/Lib/test/support/__init__.py
+++ b/Lib/test/support/__init__.py
@@ -1197,6 +1197,7 @@ def no_rerun(reason):
     test using the 'reason' parameter.
     """
     def deco(func):
+        assert not isinstance(func, type), func
         _has_run = False
         def wrapper(self):
             nonlocal _has_run

_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]

Reply via email to