https://github.com/python/cpython/commit/a81d434c06335b0989ba83666ec7076b9d9d4e1e
commit: a81d434c06335b0989ba83666ec7076b9d9d4e1e
branch: main
author: neonene <[email protected]>
committer: kumaraditya303 <[email protected]>
date: 2024-06-21T22:39:33+05:30
summary:
gh-120782: Update internal type cache when reloading datetime (#120829)
files:
A Misc/NEWS.d/next/Library/2024-06-21-12-00-16.gh-issue-120782.LOE8tj.rst
M Lib/test/datetimetester.py
M Modules/_datetimemodule.c
diff --git a/Lib/test/datetimetester.py b/Lib/test/datetimetester.py
index e55b738eb4a975..b8f69e774f7990 100644
--- a/Lib/test/datetimetester.py
+++ b/Lib/test/datetimetester.py
@@ -6870,6 +6870,23 @@ def pickle_fake_date(datetime_) -> Type[FakeDate]:
""")
script_helper.assert_python_ok('-c', script)
+ def test_update_type_cache(self):
+ # gh-120782
+ script = textwrap.dedent("""
+ import sys
+ for i in range(5):
+ import _datetime
+ _datetime.date.max > _datetime.date.min
+ _datetime.time.max > _datetime.time.min
+ _datetime.datetime.max > _datetime.datetime.min
+ _datetime.timedelta.max > _datetime.timedelta.min
+ isinstance(_datetime.timezone.min, _datetime.tzinfo)
+ isinstance(_datetime.timezone.utc, _datetime.tzinfo)
+ isinstance(_datetime.timezone.max, _datetime.tzinfo)
+ del sys.modules['_datetime']
+ """)
+ script_helper.assert_python_ok('-c', script)
+
def load_tests(loader, standard_tests, pattern):
standard_tests.addTest(ZoneInfoCompleteTest())
diff --git
a/Misc/NEWS.d/next/Library/2024-06-21-12-00-16.gh-issue-120782.LOE8tj.rst
b/Misc/NEWS.d/next/Library/2024-06-21-12-00-16.gh-issue-120782.LOE8tj.rst
new file mode 100644
index 00000000000000..02acbd2873009b
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2024-06-21-12-00-16.gh-issue-120782.LOE8tj.rst
@@ -0,0 +1 @@
+Fix wrong references of the :mod:`datetime` types after reloading the module.
diff --git a/Modules/_datetimemodule.c b/Modules/_datetimemodule.c
index 31bf641152d803..85595dce0bad5c 100644
--- a/Modules/_datetimemodule.c
+++ b/Modules/_datetimemodule.c
@@ -7296,6 +7296,12 @@ _datetime_exec(PyObject *module)
static_assert(DI100Y == 25 * DI4Y - 1, "DI100Y");
assert(DI100Y == days_before_year(100+1));
+ if (reloading) {
+ for (size_t i = 0; i < Py_ARRAY_LENGTH(capi_types); i++) {
+ PyType_Modified(capi_types[i]);
+ }
+ }
+
if (set_current_module(interp, module) < 0) {
goto error;
}
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
