https://github.com/python/cpython/commit/10818024c876c17d6ce1ebfaaa88e02607abb2f6
commit: 10818024c876c17d6ce1ebfaaa88e02607abb2f6
branch: 3.12
author: Vinay Sajip <[email protected]>
committer: vsajip <[email protected]>
date: 2024-07-03T11:40:26+01:00
summary:

[3.12] gh-121035: Further improve logging flow diagram with respect to 
dark/light modes. (GH-121265) (GH-121321)

(cherry picked from commit 089835469d5efbea4793cd611b43cb8387f2e7e5)

files:
M Doc/howto/logging.rst
M Doc/howto/logging_flow.svg

diff --git a/Doc/howto/logging.rst b/Doc/howto/logging.rst
index 3f3cb55cfe9035..b96ff7fd20ee20 100644
--- a/Doc/howto/logging.rst
+++ b/Doc/howto/logging.rst
@@ -402,11 +402,13 @@ following diagram.
      function updateBody(theme) {
         let elem = document.body;
 
+        elem.classList.remove('dark-theme');
+        elem.classList.remove('light-theme');
         if (theme === 'dark') {
             elem.classList.add('dark-theme');
         }
-        else {
-            elem.classList.remove('dark-theme');
+        else if (theme === 'light') {
+            elem.classList.add('light-theme');
         }
      }
 
diff --git a/Doc/howto/logging_flow.svg b/Doc/howto/logging_flow.svg
index 9807323b7190d6..4974994ac6b400 100644
--- a/Doc/howto/logging_flow.svg
+++ b/Doc/howto/logging_flow.svg
@@ -46,6 +46,7 @@
         filter: invert(100%) hue-rotate(180deg) saturate(1.25);
       }
     }
+    /* These rules are for when the theme selector is used, perhaps in 
contrast to the browser theme. */
     body.dark-theme polygon, body.dark-theme rect, body.dark-theme polyline, 
body.dark-theme line {
       stroke: #ffffff;
     }
@@ -55,6 +56,15 @@
     body.dark-theme text {
       fill: #ffffff;
     }
+    body.light-theme polygon, body.light-theme rect, body.light-theme 
polyline, body.light-theme line {
+      stroke: #000000;
+    }
+    body.light-theme polygon.filled {
+      fill: #000000;
+    }
+    body.light-theme text {
+      fill: #000000;
+    }
   </style>
 
   <defs />

_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]

Reply via email to