https://github.com/python/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162
commit: 263c7e611bb24715e513d457a3477a61fff15162
branch: main
author: Petr Viktorin <[email protected]>
committer: encukou <[email protected]>
date: 2024-07-16T16:09:08+02:00
summary:
gh-121160: Add some tests for readline.set_history_length (GH-121326)
files:
A Misc/NEWS.d/next/Tests/2024-07-03-14-41-00.gh-issue-121160.LEtiTd.rst
M Lib/test/test_readline.py
diff --git a/Lib/test/test_readline.py b/Lib/test/test_readline.py
index 5e0e6f8dfac651..91fd7dd13f9063 100644
--- a/Lib/test/test_readline.py
+++ b/Lib/test/test_readline.py
@@ -132,6 +132,32 @@ def test_nonascii_history(self):
self.assertEqual(readline.get_history_item(1), "entrée 1")
self.assertEqual(readline.get_history_item(2), "entrée 22")
+ def test_write_read_limited_history(self):
+ previous_length = readline.get_history_length()
+ self.addCleanup(readline.set_history_length, previous_length)
+
+ readline.clear_history()
+ readline.add_history("first line")
+ readline.add_history("second line")
+ readline.add_history("third line")
+
+ readline.set_history_length(2)
+ self.assertEqual(readline.get_history_length(), 2)
+ readline.write_history_file(TESTFN)
+ self.addCleanup(os.remove, TESTFN)
+
+ readline.clear_history()
+ self.assertEqual(readline.get_current_history_length(), 0)
+ self.assertEqual(readline.get_history_length(), 2)
+
+ readline.read_history_file(TESTFN)
+ self.assertEqual(readline.get_history_item(1), "second line")
+ self.assertEqual(readline.get_history_item(2), "third line")
+ self.assertEqual(readline.get_history_item(3), None)
+
+ # Readline seems to report an additional history element.
+ self.assertIn(readline.get_current_history_length(), (2, 3))
+
class TestReadline(unittest.TestCase):
@@ -323,6 +349,26 @@ def test_history_size(self):
self.assertEqual(len(lines), history_size)
self.assertEqual(lines[-1].strip(), b"last input")
+ def test_write_read_limited_history(self):
+ previous_length = readline.get_history_length()
+ self.addCleanup(readline.set_history_length, previous_length)
+
+ readline.add_history("first line")
+ readline.add_history("second line")
+ readline.add_history("third line")
+
+ readline.set_history_length(2)
+ self.assertEqual(readline.get_history_length(), 2)
+ readline.write_history_file(TESTFN)
+ self.addCleanup(os.remove, TESTFN)
+
+ readline.read_history_file(TESTFN)
+ # Without clear_history() there's no good way to test if
+ # the correct entries are present (we're combining history limiting and
+ # possible deduplication with arbitrary previous content).
+ # So, we've only tested that the read did not fail.
+ # See TestHistoryManipulation for the full test.
+
if __name__ == "__main__":
unittest.main()
diff --git
a/Misc/NEWS.d/next/Tests/2024-07-03-14-41-00.gh-issue-121160.LEtiTd.rst
b/Misc/NEWS.d/next/Tests/2024-07-03-14-41-00.gh-issue-121160.LEtiTd.rst
new file mode 100644
index 00000000000000..2c8c9ac7201836
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2024-07-03-14-41-00.gh-issue-121160.LEtiTd.rst
@@ -0,0 +1,2 @@
+Add a test for :func:`readline.set_history_length`. Note that this test may
+fail on readline libraries.
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
