https://github.com/python/cpython/commit/c15bfa9a71c8b7ce7ff6d8486f51aab566e8d81d
commit: c15bfa9a71c8b7ce7ff6d8486f51aab566e8d81d
branch: main
author: sobolevn <[email protected]>
committer: sobolevn <[email protected]>
date: 2024-08-18T18:42:56+03:00
summary:
gh-116789: Add more tests for `inspect.getmembers` (#116802)
files:
M Lib/test/test_inspect/test_inspect.py
diff --git a/Lib/test/test_inspect/test_inspect.py
b/Lib/test/test_inspect/test_inspect.py
index 730c192d1aa260..aa6552536b56e0 100644
--- a/Lib/test/test_inspect/test_inspect.py
+++ b/Lib/test/test_inspect/test_inspect.py
@@ -1550,6 +1550,56 @@ def f(self):
self.assertIn(('f', b.f), inspect.getmembers(b))
self.assertIn(('f', b.f), inspect.getmembers(b, inspect.ismethod))
+ def test_getmembers_custom_dir(self):
+ class CorrectDir:
+ def __init__(self, attr):
+ self.attr = attr
+ def method(self):
+ return self.attr + 1
+ def __dir__(self):
+ return ['attr', 'method']
+
+ cd = CorrectDir(5)
+ self.assertEqual(inspect.getmembers(cd), [
+ ('attr', 5),
+ ('method', cd.method),
+ ])
+ self.assertEqual(inspect.getmembers(cd, inspect.ismethod), [
+ ('method', cd.method),
+ ])
+
+ def test_getmembers_custom_broken_dir(self):
+ # inspect.getmembers calls `dir()` on the passed object inside.
+ # if `__dir__` mentions some non-existent attribute,
+ # we still need to return others correctly.
+ class BrokenDir:
+ existing = 1
+ def method(self):
+ return self.existing + 1
+ def __dir__(self):
+ return ['method', 'missing', 'existing']
+
+ bd = BrokenDir()
+ self.assertEqual(inspect.getmembers(bd), [
+ ('existing', 1),
+ ('method', bd.method),
+ ])
+ self.assertEqual(inspect.getmembers(bd, inspect.ismethod), [
+ ('method', bd.method),
+ ])
+
+ def test_getmembers_custom_duplicated_dir(self):
+ # Duplicates in `__dir__` must not fail and return just one result.
+ class DuplicatedDir:
+ attr = 1
+ def __dir__(self):
+ return ['attr', 'attr']
+
+ dd = DuplicatedDir()
+ self.assertEqual(inspect.getmembers(dd), [
+ ('attr', 1),
+ ])
+
def test_getmembers_VirtualAttribute(self):
class M(type):
def __getattr__(cls, name):
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
