https://github.com/python/cpython/commit/9c98fdab7d1167211c9d162c418e2b443a02867a
commit: 9c98fdab7d1167211c9d162c418e2b443a02867a
branch: main
author: Kirill Podoprigora <[email protected]>
committer: Eclips4 <[email protected]>
date: 2024-09-26T15:30:21Z
summary:

gh-124606: Fix reference leak in error path in `datetime_fromisoformat` in 
`_datetimemodule.c` (#124607)

Previously `tzdata` and `dtstr_clean` were not decrefed in the 
`invalid_iso_midnight` error path of the `datetime_isoformat` function.

files:
M Modules/_datetimemodule.c

diff --git a/Modules/_datetimemodule.c b/Modules/_datetimemodule.c
index 0d91bef2ff9bda..90527d2a3e0350 100644
--- a/Modules/_datetimemodule.c
+++ b/Modules/_datetimemodule.c
@@ -5959,6 +5959,8 @@ datetime_fromisoformat(PyObject *cls, PyObject *dtstr)
 
 invalid_iso_midnight:
     PyErr_SetString(PyExc_ValueError, "minute, second, and microsecond must be 
0 when hour is 24");
+    Py_DECREF(tzinfo);
+    Py_DECREF(dtstr_clean);
     return NULL;
 
 invalid_string_error:

_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]

Reply via email to