https://github.com/python/cpython/commit/55c4f4c30b49734ce35dc88139b8b4fdc94c66fd
commit: 55c4f4c30b49734ce35dc88139b8b4fdc94c66fd
branch: main
author: Irit Katriel <[email protected]>
committer: iritkatriel <[email protected]>
date: 2024-10-15T15:11:02+01:00
summary:
gh-125514: fix bug in test_traceback utility. Specify exception types in
except: clauses (#125516)
files:
M Lib/test/test_traceback.py
diff --git a/Lib/test/test_traceback.py b/Lib/test/test_traceback.py
index 455fea034198a6..77ef0c5b3c480d 100644
--- a/Lib/test/test_traceback.py
+++ b/Lib/test/test_traceback.py
@@ -150,7 +150,7 @@ def
test_no_caret_with_no_debug_ranges_flag_python_traceback(self):
import traceback
try:
x = 1 / 0
- except:
+ except ZeroDivisionError:
traceback.print_exc()
""")
try:
@@ -550,9 +550,10 @@ class PurePythonExceptionFormattingMixin:
def get_exception(self, callable, slice_start=0, slice_end=-1):
try:
callable()
- self.fail("No exception thrown.")
- except:
+ except BaseException:
return traceback.format_exc().splitlines()[slice_start:slice_end]
+ else:
+ self.fail("No exception thrown.")
callable_line = get_exception.__code__.co_firstlineno + 2
@@ -2237,7 +2238,7 @@ def test_context_suppression(self):
try:
try:
raise Exception
- except:
+ except Exception:
raise ZeroDivisionError from None
except ZeroDivisionError as _:
e = _
@@ -2589,9 +2590,9 @@ def exc():
try:
try:
raise EG("eg1", [ValueError(1), TypeError(2)])
- except:
+ except EG:
raise EG("eg2", [ValueError(3), TypeError(4)])
- except:
+ except EG:
raise ImportError(5)
expected = (
@@ -2641,7 +2642,7 @@ def exc():
except Exception as e:
exc = e
raise EG("eg", [VE(1), exc, VE(4)])
- except:
+ except EG:
raise EG("top", [VE(5)])
expected = (f' + Exception Group Traceback (most recent call last):\n'
@@ -3454,7 +3455,7 @@ def test_long_context_chain(self):
def f():
try:
1/0
- except:
+ except ZeroDivisionError:
f()
try:
@@ -3558,7 +3559,7 @@ def test_comparison_params_variations(self):
def raise_exc():
try:
raise ValueError('bad value')
- except:
+ except ValueError:
raise
def raise_with_locals():
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
