https://github.com/python/cpython/commit/616692d465c4ef10baa592e41f3d9daeae4dddad
commit: 616692d465c4ef10baa592e41f3d9daeae4dddad
branch: main
author: Hood Chatham <[email protected]>
committer: freakboy3742 <[email protected]>
date: 2025-01-07T06:25:29+08:00
summary:
gh-127146: Skip Emscripten tests with pending fixes (#128549)
Marks some additional tests as skipped on Emscripten. Many of these skips can be
reverted when the next Emscripten release is available.
files:
M Lib/test/test_io.py
M Lib/test/test_os.py
M Lib/test/test_shutil.py
M Lib/test/test_tarfile.py
M Lib/test/test_zipfile/test_core.py
M Lib/test/test_zipimport.py
diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
index 81c17b2731cc58..33e0161241e87e 100644
--- a/Lib/test/test_io.py
+++ b/Lib/test/test_io.py
@@ -3933,6 +3933,7 @@ def test_issue35928(self):
self.assertEqual(res + f.readline(), 'foo\nbar\n')
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
+ @unittest.skipIf(support.is_emscripten, "Would be fixed by
emscripten-core/emscripten#23306")
def test_read_non_blocking(self):
import os
r, w = os.pipe()
diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
index d688a225538c11..d2c4dff3c9a0e5 100644
--- a/Lib/test/test_os.py
+++ b/Lib/test/test_os.py
@@ -4979,6 +4979,7 @@ def test_unpickable(self):
self.assertRaises(TypeError, pickle.dumps, scandir_iter, filename)
scandir_iter.close()
+ @unittest.skipIf(support.is_emscripten, "Fixed by
emscripten-core/emscripten#23139, remove when next Emscripten release comes
out")
def check_entry(self, entry, name, is_dir, is_file, is_symlink):
self.assertIsInstance(entry, os.DirEntry)
self.assertEqual(entry.name, name)
diff --git a/Lib/test/test_shutil.py b/Lib/test/test_shutil.py
index 1f18b1f09b5858..2d79d2ffede461 100644
--- a/Lib/test/test_shutil.py
+++ b/Lib/test/test_shutil.py
@@ -1587,6 +1587,7 @@ def test_copyfile_same_file(self):
# the path as a directory, but on AIX the trailing slash has no effect
# and is considered as a file.
@unittest.skipIf(AIX, 'Not valid on AIX, see gh-92670')
+ @unittest.skipIf(support.is_emscripten, 'Fixed by
emscripten-core/emscripten#23218, remove when next Emscripten release comes
out')
def test_copyfile_nonexistent_dir(self):
# Issue 43219
src_dir = self.mkdtemp()
diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py
index 54d329a15d4d25..2549b6b35adc29 100644
--- a/Lib/test/test_tarfile.py
+++ b/Lib/test/test_tarfile.py
@@ -3800,6 +3800,7 @@ def test_absolute_hardlink(self):
"'parent' is a link to an absolute path")
@symlink_test
+ @unittest.skipIf(support.is_emscripten, "Fixed by
emscripten-core/emscripten#23136, remove when next Emscripten release comes
out")
def test_sly_relative0(self):
# Inspired by 'relative0' in jwilk/traversal-archives
with ArchiveMaker() as arc:
diff --git a/Lib/test/test_zipfile/test_core.py
b/Lib/test/test_zipfile/test_core.py
index 49f39b9337df85..79e7337606b4bc 100644
--- a/Lib/test/test_zipfile/test_core.py
+++ b/Lib/test/test_zipfile/test_core.py
@@ -22,7 +22,8 @@
from test.support import script_helper
from test.support import (
findfile, requires_zlib, requires_bz2, requires_lzma,
- captured_stdout, captured_stderr, requires_subprocess
+ captured_stdout, captured_stderr, requires_subprocess,
+ is_emscripten
)
from test.support.os_helper import (
TESTFN, unlink, rmtree, temp_dir, temp_cwd, fd_count, FakePath
@@ -622,6 +623,7 @@ def test_write_to_readonly(self):
with self.assertRaises(ValueError):
zipfp.open(TESTFN, mode='w')
+ @unittest.skipIf(is_emscripten, "Fixed by
emscripten-core/emscripten#23310")
def test_add_file_before_1980(self):
# Set atime and mtime to 1970-01-01
os.utime(TESTFN, (0, 0))
diff --git a/Lib/test/test_zipimport.py b/Lib/test/test_zipimport.py
index 1f288c8b45d589..65f8b17f2f88c0 100644
--- a/Lib/test/test_zipimport.py
+++ b/Lib/test/test_zipimport.py
@@ -1038,6 +1038,7 @@ def testEmptyFile(self):
self.assertZipFailure(TESTMOD)
@unittest.skipIf(support.is_wasi, "mode 000 not supported.")
+ @unittest.skipIf(support.is_emscripten, "Fixed by
emscripten-core/emscripten#23137, remove when next Emscripten release comes
out")
def testFileUnreadable(self):
os_helper.unlink(TESTMOD)
fd = os.open(TESTMOD, os.O_CREAT, 000)
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
