https://github.com/python/cpython/commit/8e57877e3f43e80762196f6869526d0c1585783a
commit: 8e57877e3f43e80762196f6869526d0c1585783a
branch: main
author: Hood Chatham <[email protected]>
committer: freakboy3742 <[email protected]>
date: 2025-01-28T01:05:21Z
summary:
gh-127146: Update test skips for Emscripten 4.0.1 (#129375)
Updates the Emscripten test skips to reflect recent changes in Emscripten
capabilities.
files:
M Lib/test/test_genericpath.py
M Lib/test/test_io.py
M Lib/test/test_ntpath.py
M Lib/test/test_os.py
M Lib/test/test_shutil.py
M Lib/test/test_signal.py
M Lib/test/test_tarfile.py
M Lib/test/test_zipfile/test_core.py
M Lib/test/test_zipimport.py
diff --git a/Lib/test/test_genericpath.py b/Lib/test/test_genericpath.py
index 6d2593cb4cf228..391158b855624d 100644
--- a/Lib/test/test_genericpath.py
+++ b/Lib/test/test_genericpath.py
@@ -161,7 +161,7 @@ def test_exists(self):
self.assertIs(self.pathmodule.lexists(path=filename), True)
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
- @unittest.skipIf(is_emscripten, "Emscripten pipe fds have no stat")
+ @unittest.skipIf(is_emscripten, "Fixed in next Emscripten release after
4.0.1")
def test_exists_fd(self):
r, w = os.pipe()
try:
diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
index 8c79d2c24a140a..e59d3977df4134 100644
--- a/Lib/test/test_io.py
+++ b/Lib/test/test_io.py
@@ -3928,7 +3928,7 @@ def test_issue35928(self):
self.assertEqual(res + f.readline(), 'foo\nbar\n')
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
- @unittest.skipIf(support.is_emscripten, "Would be fixed by
emscripten-core/emscripten#23306")
+ @unittest.skipIf(support.is_emscripten, "Fixed in next Emscripten release
after 4.0.1")
def test_read_non_blocking(self):
import os
r, w = os.pipe()
diff --git a/Lib/test/test_ntpath.py b/Lib/test/test_ntpath.py
index 6715071af8c752..da01c65a1c2954 100644
--- a/Lib/test/test_ntpath.py
+++ b/Lib/test/test_ntpath.py
@@ -940,7 +940,7 @@ def check_error(paths, expected):
self.assertRaises(TypeError, ntpath.commonpath, ['C:\\Foo',
b'Foo\\Baz'])
self.assertRaises(TypeError, ntpath.commonpath, ['Foo',
b'C:\\Foo\\Baz'])
- @unittest.skipIf(is_emscripten, "Emscripten cannot fstat unnamed files.")
+ @unittest.skipIf(is_emscripten, "Fixed in next Emscripten release after
4.0.1")
def test_sameopenfile(self):
with TemporaryFile() as tf1, TemporaryFile() as tf2:
# Make sure the same file is really the same
diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
index d1bdf784b0df16..72208d1c582568 100644
--- a/Lib/test/test_os.py
+++ b/Lib/test/test_os.py
@@ -5093,7 +5093,6 @@ def test_unpickable(self):
self.assertRaises(TypeError, pickle.dumps, scandir_iter, filename)
scandir_iter.close()
- @unittest.skipIf(support.is_emscripten, "Fixed by
emscripten-core/emscripten#23139, remove when next Emscripten release comes
out")
def check_entry(self, entry, name, is_dir, is_file, is_symlink):
self.assertIsInstance(entry, os.DirEntry)
self.assertEqual(entry.name, name)
diff --git a/Lib/test/test_shutil.py b/Lib/test/test_shutil.py
index 2d79d2ffede461..1f18b1f09b5858 100644
--- a/Lib/test/test_shutil.py
+++ b/Lib/test/test_shutil.py
@@ -1587,7 +1587,6 @@ def test_copyfile_same_file(self):
# the path as a directory, but on AIX the trailing slash has no effect
# and is considered as a file.
@unittest.skipIf(AIX, 'Not valid on AIX, see gh-92670')
- @unittest.skipIf(support.is_emscripten, 'Fixed by
emscripten-core/emscripten#23218, remove when next Emscripten release comes
out')
def test_copyfile_nonexistent_dir(self):
# Issue 43219
src_dir = self.mkdtemp()
diff --git a/Lib/test/test_signal.py b/Lib/test/test_signal.py
index 704a0090bdbc0f..96ae79b0eb18b3 100644
--- a/Lib/test/test_signal.py
+++ b/Lib/test/test_signal.py
@@ -253,9 +253,7 @@ def test_invalid_socket(self):
self.assertRaises((ValueError, OSError),
signal.set_wakeup_fd, fd)
- # Emscripten does not support fstat on pipes yet.
- # https://github.com/emscripten-core/emscripten/issues/16414
- @unittest.skipIf(support.is_emscripten, "Emscripten cannot fstat pipes.")
+ @unittest.skipIf(support.is_emscripten, "Fixed in next Emscripten release
after 4.0.1")
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
def test_set_wakeup_fd_result(self):
r1, w1 = os.pipe()
@@ -274,7 +272,7 @@ def test_set_wakeup_fd_result(self):
self.assertEqual(signal.set_wakeup_fd(-1), w2)
self.assertEqual(signal.set_wakeup_fd(-1), -1)
- @unittest.skipIf(support.is_emscripten, "Emscripten cannot fstat pipes.")
+ @unittest.skipIf(support.is_emscripten, "Fixed in next Emscripten release
after 4.0.1")
@unittest.skipUnless(support.has_socket_support, "needs working sockets.")
def test_set_wakeup_fd_socket_result(self):
sock1 = socket.socket()
@@ -295,7 +293,7 @@ def test_set_wakeup_fd_socket_result(self):
# On Windows, files are always blocking and Windows does not provide a
# function to test if a socket is in non-blocking mode.
@unittest.skipIf(sys.platform == "win32", "tests specific to POSIX")
- @unittest.skipIf(support.is_emscripten, "Emscripten cannot fstat pipes.")
+ @unittest.skipIf(support.is_emscripten, "Fixed in next Emscripten release
after 4.0.1")
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
def test_set_wakeup_fd_blocking(self):
rfd, wfd = os.pipe()
diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py
index 2549b6b35adc29..54d329a15d4d25 100644
--- a/Lib/test/test_tarfile.py
+++ b/Lib/test/test_tarfile.py
@@ -3800,7 +3800,6 @@ def test_absolute_hardlink(self):
"'parent' is a link to an absolute path")
@symlink_test
- @unittest.skipIf(support.is_emscripten, "Fixed by
emscripten-core/emscripten#23136, remove when next Emscripten release comes
out")
def test_sly_relative0(self):
# Inspired by 'relative0' in jwilk/traversal-archives
with ArchiveMaker() as arc:
diff --git a/Lib/test/test_zipfile/test_core.py
b/Lib/test/test_zipfile/test_core.py
index 76b1de0e3519f9..6b1fe56074d561 100644
--- a/Lib/test/test_zipfile/test_core.py
+++ b/Lib/test/test_zipfile/test_core.py
@@ -624,7 +624,6 @@ def test_write_to_readonly(self):
with self.assertRaises(ValueError):
zipfp.open(TESTFN, mode='w')
- @unittest.skipIf(is_emscripten, "Fixed by
emscripten-core/emscripten#23310")
def test_add_file_before_1980(self):
# Set atime and mtime to 1970-01-01
os.utime(TESTFN, (0, 0))
diff --git a/Lib/test/test_zipimport.py b/Lib/test/test_zipimport.py
index 65f8b17f2f88c0..1f288c8b45d589 100644
--- a/Lib/test/test_zipimport.py
+++ b/Lib/test/test_zipimport.py
@@ -1038,7 +1038,6 @@ def testEmptyFile(self):
self.assertZipFailure(TESTMOD)
@unittest.skipIf(support.is_wasi, "mode 000 not supported.")
- @unittest.skipIf(support.is_emscripten, "Fixed by
emscripten-core/emscripten#23137, remove when next Emscripten release comes
out")
def testFileUnreadable(self):
os_helper.unlink(TESTMOD)
fd = os.open(TESTMOD, os.O_CREAT, 000)
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
