https://github.com/python/cpython/commit/3ebe3d7688475e98a34d691e1ba50d8b7178a575
commit: 3ebe3d7688475e98a34d691e1ba50d8b7178a575
branch: main
author: Cody Maloney <[email protected]>
committer: vstinner <[email protected]>
date: 2025-01-31T09:40:44+01:00
summary:
Revert "gh-129005: _pyio.BufferedIO remove copy on readall (#129454)" (#129500)
This reverts commit e1c4ba928852eac0b0e0bded1c314e3e36975286.
files:
D Misc/NEWS.d/next/Library/2025-01-29-00-00-01.gh-issue-129005.aV_3O8.rst
M Lib/_pyio.py
diff --git a/Lib/_pyio.py b/Lib/_pyio.py
index 755e0258770891..76a27910da4d5f 100644
--- a/Lib/_pyio.py
+++ b/Lib/_pyio.py
@@ -1062,9 +1062,6 @@ def _read_unlocked(self, n=None):
if chunk is None:
return buf[pos:] or None
else:
- # Avoid slice + copy if there is no data in buf
- if not buf:
- return chunk
return buf[pos:] + chunk
chunks = [buf[pos:]] # Strip the consumed bytes.
current_size = 0
diff --git
a/Misc/NEWS.d/next/Library/2025-01-29-00-00-01.gh-issue-129005.aV_3O8.rst
b/Misc/NEWS.d/next/Library/2025-01-29-00-00-01.gh-issue-129005.aV_3O8.rst
deleted file mode 100644
index 48ee57109be2ff..00000000000000
--- a/Misc/NEWS.d/next/Library/2025-01-29-00-00-01.gh-issue-129005.aV_3O8.rst
+++ /dev/null
@@ -1,2 +0,0 @@
-:mod:`!_pyio`: Remove an unnecessary copy when ``_pyio.BufferedReader.read()``
-is called to read all data from a file and has no data already in buffer.
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]
