https://github.com/python/cpython/commit/cc81b63a7582217efe35dbc52bf061664ffdecea commit: cc81b63a7582217efe35dbc52bf061664ffdecea branch: 3.14 author: Miss Islington (bot) <[email protected]> committer: kumaraditya303 <[email protected]> date: 2025-05-27T18:00:19Z summary:
[3.14] gh-132917: fix data race on `last_mem` in free-threading gc (GH-134692) (#134802) gh-132917: fix data race on `last_mem` in free-threading gc (GH-134692) (cherry picked from commit ac539e7e0d1622c61988f30c91acfd4c06521ced) Co-authored-by: Kumar Aditya <[email protected]> files: M Python/gc_free_threading.c diff --git a/Python/gc_free_threading.c b/Python/gc_free_threading.c index d2ea5b5e06ba43..5aaa68c5b51f95 100644 --- a/Python/gc_free_threading.c +++ b/Python/gc_free_threading.c @@ -2062,7 +2062,7 @@ gc_should_collect_mem_usage(GCState *gcstate) // 70,000 new container objects. return true; } - Py_ssize_t last_mem = gcstate->last_mem; + Py_ssize_t last_mem = _Py_atomic_load_ssize_relaxed(&gcstate->last_mem); Py_ssize_t mem_threshold = Py_MAX(last_mem / 10, 128); if ((mem - last_mem) > mem_threshold) { // The process memory usage has increased too much, do a collection. @@ -2245,7 +2245,8 @@ gc_collect_internal(PyInterpreterState *interp, struct collection_state *state, // Store the current memory usage, can be smaller now if breaking cycles // freed some memory. - state->gcstate->last_mem = get_process_mem_usage(); + Py_ssize_t last_mem = get_process_mem_usage(); + _Py_atomic_store_ssize_relaxed(&state->gcstate->last_mem, last_mem); // Append objects with legacy finalizers to the "gc.garbage" list. handle_legacy_finalizers(state); _______________________________________________ Python-checkins mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3//lists/python-checkins.python.org Member address: [email protected]
