https://github.com/python/cpython/commit/171de05b4884d1353044417ea51a4efcb55ba633
commit: 171de05b4884d1353044417ea51a4efcb55ba633
branch: main
author: Sachin Shah <[email protected]>
committer: serhiy-storchaka <[email protected]>
date: 2025-07-13T08:49:12+03:00
summary:
gh-136523: Fix wave.Wave_write emitting an unraisable when open raises
(GH-136529)
files:
A Misc/NEWS.d/next/Library/2025-07-11-03-39-15.gh-issue-136523.s7caKL.rst
M Lib/test/test_wave.py
M Lib/wave.py
diff --git a/Lib/test/test_wave.py b/Lib/test/test_wave.py
index 6c3362857fc2ba..226b1aa84bd73c 100644
--- a/Lib/test/test_wave.py
+++ b/Lib/test/test_wave.py
@@ -2,6 +2,7 @@
from test import audiotests
from test import support
import io
+import os
import struct
import sys
import wave
@@ -196,6 +197,14 @@ def test_read_wrong_sample_width(self):
with self.assertRaisesRegex(wave.Error, 'bad sample width'):
wave.open(io.BytesIO(b))
+ def test_open_in_write_raises(self):
+ # gh-136523: Wave_write.__del__ should not throw
+ with support.catch_unraisable_exception() as cm:
+ with self.assertRaises(OSError):
+ wave.open(os.curdir, "wb")
+ support.gc_collect()
+ self.assertIsNone(cm.unraisable)
+
if __name__ == '__main__':
unittest.main()
diff --git a/Lib/wave.py b/Lib/wave.py
index 929609fa52409d..5af745e2217ec3 100644
--- a/Lib/wave.py
+++ b/Lib/wave.py
@@ -427,6 +427,8 @@ class Wave_write:
_datawritten -- the size of the audio samples actually written
"""
+ _file = None
+
def __init__(self, f):
self._i_opened_the_file = None
if isinstance(f, str):
diff --git
a/Misc/NEWS.d/next/Library/2025-07-11-03-39-15.gh-issue-136523.s7caKL.rst
b/Misc/NEWS.d/next/Library/2025-07-11-03-39-15.gh-issue-136523.s7caKL.rst
new file mode 100644
index 00000000000000..71ec66a37ef4c3
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2025-07-11-03-39-15.gh-issue-136523.s7caKL.rst
@@ -0,0 +1 @@
+Fix :class:`wave.Wave_write` emitting an unraisable when open raises.
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
