https://github.com/python/cpython/commit/22af5d35a620ee44393853036a8450ceb047688e
commit: 22af5d35a620ee44393853036a8450ceb047688e
branch: main
author: Hood Chatham <[email protected]>
committer: freakboy3742 <[email protected]>
date: 2025-07-17T15:39:01Z
summary:
gh-127146: Emscripten: Set umask to zero in python.sh (#136740)
Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
files:
M Lib/test/test_pydoc/test_pydoc.py
diff --git a/Lib/test/test_pydoc/test_pydoc.py
b/Lib/test/test_pydoc/test_pydoc.py
index d1d6f4987def0c..005526d994bd62 100644
--- a/Lib/test/test_pydoc/test_pydoc.py
+++ b/Lib/test/test_pydoc/test_pydoc.py
@@ -1303,6 +1303,11 @@ def test_apropos_with_unreadable_dir(self):
@os_helper.skip_unless_working_chmod
def test_apropos_empty_doc(self):
pkgdir = os.path.join(TESTFN, 'walkpkg')
+ if support.is_emscripten:
+ # Emscripten's readdir implementation is buggy on directories
+ # with read permission but no execute permission.
+ old_umask = os.umask(0)
+ self.addCleanup(os.umask, old_umask)
os.mkdir(pkgdir)
self.addCleanup(rmtree, pkgdir)
init_path = os.path.join(pkgdir, '__init__.py')
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
