https://github.com/python/cpython/commit/620a5b92693ac1b2cef1f90fd3c2dba1bb794552
commit: 620a5b92693ac1b2cef1f90fd3c2dba1bb794552
branch: main
author: Bartosz Sławecki <[email protected]>
committer: serhiy-storchaka <[email protected]>
date: 2026-01-11T21:24:19+02:00
summary:
gh-127750: Fix annotations in singledispatchmethod signature tests (GH-143571)
These tests relied on a bug -- gh-84644, which is that singledispatch
doesn't verify the annotation is on the "first" parameter.
files:
M Lib/test/test_functools.py
diff --git a/Lib/test/test_functools.py b/Lib/test/test_functools.py
index 459d56f82d6820..94b469397139c7 100644
--- a/Lib/test/test_functools.py
+++ b/Lib/test/test_functools.py
@@ -3450,16 +3450,11 @@ def _(item: int, arg: bytes) -> str:
def test_method_signatures(self):
class A:
- def m(self, item, arg: int) -> str:
- return str(item)
- @classmethod
- def cm(cls, item, arg: int) -> str:
- return str(item)
@functools.singledispatchmethod
def func(self, item, arg: int) -> str:
return str(item)
@func.register
- def _(self, item, arg: bytes) -> str:
+ def _(self, item: int, arg: bytes) -> str:
return str(item)
@functools.singledispatchmethod
@@ -3468,7 +3463,7 @@ def cls_func(cls, item, arg: int) -> str:
return str(arg)
@func.register
@classmethod
- def _(cls, item, arg: bytes) -> str:
+ def _(cls, item: int, arg: bytes) -> str:
return str(item)
@functools.singledispatchmethod
@@ -3477,7 +3472,7 @@ def static_func(item, arg: int) -> str:
return str(arg)
@func.register
@staticmethod
- def _(item, arg: bytes) -> str:
+ def _(item: int, arg: bytes) -> str:
return str(item)
self.assertEqual(str(Signature.from_callable(A.func)),
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
