https://github.com/python/cpython/commit/ea26c885fd85e7d57b7eefd72acea280ac93e467 commit: ea26c885fd85e7d57b7eefd72acea280ac93e467 branch: 3.14 author: Miss Islington (bot) <[email protected]> committer: serhiy-storchaka <[email protected]> date: 2026-01-11T19:49:30Z summary:
[3.14] gh-127750: Fix annotations in singledispatchmethod signature tests (GH-143571) (GH-143707) These tests relied on a bug -- gh-84644, which is that singledispatch doesn't verify the annotation is on the "first" parameter. (cherry picked from commit 620a5b92693ac1b2cef1f90fd3c2dba1bb794552) Co-authored-by: Bartosz Sławecki <[email protected]> files: M Lib/test/test_functools.py diff --git a/Lib/test/test_functools.py b/Lib/test/test_functools.py index 41cface3be3776..9d0cebd62ba989 100644 --- a/Lib/test/test_functools.py +++ b/Lib/test/test_functools.py @@ -3448,16 +3448,11 @@ def _(item: int, arg: bytes) -> str: def test_method_signatures(self): class A: - def m(self, item, arg: int) -> str: - return str(item) - @classmethod - def cm(cls, item, arg: int) -> str: - return str(item) @functools.singledispatchmethod def func(self, item, arg: int) -> str: return str(item) @func.register - def _(self, item, arg: bytes) -> str: + def _(self, item: int, arg: bytes) -> str: return str(item) @functools.singledispatchmethod @@ -3466,7 +3461,7 @@ def cls_func(cls, item, arg: int) -> str: return str(arg) @func.register @classmethod - def _(cls, item, arg: bytes) -> str: + def _(cls, item: int, arg: bytes) -> str: return str(item) @functools.singledispatchmethod @@ -3475,7 +3470,7 @@ def static_func(item, arg: int) -> str: return str(arg) @func.register @staticmethod - def _(item, arg: bytes) -> str: + def _(item: int, arg: bytes) -> str: return str(item) self.assertEqual(str(Signature.from_callable(A.func)), _______________________________________________ Python-checkins mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3//lists/python-checkins.python.org Member address: [email protected]
