Only committers can merge stuff. So, that would make a requirement that reviewers (and @team-of-reviwers)should be core-dev / committers.
On Wed, Aug 2, 2017 at 2:47 PM, Steve Dower <steve.do...@python.org> wrote: > Should we seed the teams from the experts list? > > > > I have no strong opinion about core vs non-core dev, but I think part of > the point of the distinction is reflected here. Why would we notify someone > about every PR in an area if we don’t want them to be committers? > > > > Top-posted from my Windows phone > > > > *From: *Terry Reedy <tjre...@udel.edu> > *Sent: *Wednesday, August 2, 2017 11:21 > *To: *python-committers@python.org > *Subject: *Re: [python-committers] mention-bot is dead,long live the > (misnamed) CODEOWNERS file! > > > > On 8/2/2017 10:37 AM, Nick Coghlan wrote: > > > On 2 August 2017 at 07:09, Christian Heimes <christ...@python.org> > wrote: > > >> I suggested teams to make the file a bit easier to maintain. The rule > > >> format works differently than the old mentionbot format. In the old > > >> format we had a relationship user -> files. The new CODEOWNERS format > > >> has files -> users mapping with last rules trumps all semantic. We have > > >> to be careful to not override parts of a previous rules. I believe teams > > >> reduce the burden. > > > > > > +1 for setting up teams, and +1 for an importlib-team :) > > > > Do people on a team have to be core-developers? > > > > Terry > > > > _______________________________________________ > > python-committers mailing list > > python-committers@python.org > > https://mail.python.org/mailman/listinfo/python-committers > > Code of Conduct: https://www.python.org/psf/codeofconduct/ > > > > _______________________________________________ > python-committers mailing list > python-committers@python.org > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ > >
_______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/