On 12/13/05, Neil Schemenauer <[EMAIL PROTECTED]> wrote: > Armin Rigo <[EMAIL PROTECTED]> wrote: > > On Mon, Dec 12, 2005 at 10:23:27PM +0100, Fredrik Lundh wrote: > >> $(AST_H) $(AST_C): $(AST_ASDL) $(ASDLGEN_FILES) > >> -$(PYTHON) $(ASDLGEN) $(AST_ASDL) > > > The same just-ignore-it behavior can bite if the script genuinely fails > > after you just made a typo in one of the input files, for example. > > Doesn't look particularly clean to me, if you want my opinion. > > Perhaps a good solution would be to have a separate make rule for > generating the AST code (i.e. not included in the overall dependancy > graph). That increases the chance that they don't get regenerated > when they should but people hacking on the AST files should notice > the error pretty easily. Other people should always be able to > build from the files checked in to SVN and so having the dependancy > there is just a source of trouble. >
Sounds reasonable to me. Would just need to make sure that it is documented in the proper places so people know to do it. -Brett _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
