On Tue, Jul 10, 2018 at 2:00 AM Terry Reedy <tjre...@udel.edu> wrote:
> On 7/9/2018 9:00 PM, Guido van Rossum wrote: > > We strongly prefer feedback in the form of Pull Requests to the peps > > repo (the file is at > > https://github.com/python/peps/blob/master/pep-0572.rst > > <https://github.com/python/peps/blob/master/pep-0572.rst>). > > I couple of people have said they don't know how to make pull requests > against a PEP. I believe the following works with the web editor. > > 1. Go to url above. > 2. Click upper right pencil icon. I don't know just who can do this. > 3. Edit on the web page. It might be easier to read the html and then > use browser find to change anything seen. > 4. Note that there are two scrollbars -- one for webpage and one for > editing box. > 5. At the bottom of the webpage, click 'Create a new branch for this > commit and start a PR'. This should unclick 'Commit directly to the > master branch.' > 6. Click Green [Propose file change] button. > 7. I expect one will end up on the PR diff page. If not, click 'files > changed to get there. Add comments explaining changes that need such. > This is almost precisely how I, a newbie to contributing, fixed a typo in this PEP tonight. At step 2, anyone who is logged in can click the pencil icon; if you don't have write access to the repo, GitHub automatically forks the repo and commits your change to a new branch within your fork, eliminating step 5. The problem I see with this is that I don't know of any way to accept or > reject the different proposed changes within the PR. If there is, I > would like to know how. > I don't believe there is a way to merge part of a PR. The rejected changes would have to be reverted with a new commit prior to merging. -- > Terry Jan Reedy > > _______________________________________________ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > https://mail.python.org/mailman/options/python-dev/jcgoble3%40gmail.com >
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com