On 26.04.21 23:55, Irit Katriel via Python-Dev wrote: > > Re https://bugs.python.org/issue40608 <https://bugs.python.org/issue40608>. > > I think it will be an act of kindness to > deprecate Py_TRASHCAN_SAFE_BEGIN/END in 3.10 and tell people to > use Py_TRASHCAN_BEGIN/END instead. > > TL;DR: There was a change in 3.8 that introduced the latter while > leaving the former for backwards compatibility, but also inadvertently > breaking them. This is not an easy bug to deal with in the wild, we > found it because we have a unit test in our codebase referencing > https://bugs.python.org/issue16602 <http://bugs.python.org/issue16602>. > A deprecation note pointing to the new macros would have made it easier. > > Is there any reason not to deprecate the old macros?
Just a note (I'm happy that this old code is still in use :) ), can't we think of replacing it somehow by functions in the case of the Limited API? The API is so often used that it would make sense to _always_ don't crash deeply nested structures. Or do you think it makes no sense at all? Then let's turn it into a no-op. But the current mixed situation is not really pleasant. -- Christian Tismer-Sperling :^) tis...@stackless.com Software Consulting : http://www.stackless.com/ Strandstraße 37 : https://github.com/PySide 24217 Schönberg : GPG key -> 0xFB7BEE0E phone +49 173 24 18 776 fax +49 (30) 700143-0023 _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/NMUWHCHY3JZXQFQZERP5PXJEVF2PJ7KC/ Code of Conduct: http://python.org/psf/codeofconduct/
