On 4/10/06, Neal Norwitz <[EMAIL PROTECTED]> wrote: > On 4/10/06, Phillip J. Eby <[EMAIL PROTECTED]> wrote: > > > > It appears the problem is an object/mem mismatch: both PyOS_Readline in > > pgenmain.c, and PyOS_StdioReadline use PyObject_MALLOC, but bltinmodule.c > > is freeing the pointer with PyMem_FREE. > > This (Readline using PyObject) was due to my recent change to fix > Guido's problem last night. > I didn't realize anything seeped out. All calls to PyOS_StdioReadline > would need to be updated. I can do that tonight. Hmm, that means this > will be an API change. I wonder if I should revert my fix and just > deal with a second alloc and copy of the data to fix Guido's original > problem.
I partially reverted my fix from last night. It appears to work for both Guido's original problem and Phillip's subsequent problem. YMMV. It would be great if someone could review all the PyMem_* and PyObject_* allocs and frees to ensure consistency. I wonder if the code would be clearer if the encoding was changed back to using PyObject_*. Then there would only be a few clear cases for using PyMem_* in Parser/. n _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
