Thomas Heller schrieb:
> I think this fixes the leak in Lib/test/leakers/test_gestalt.py.
> 
> Index: Python/mactoolboxglue.c
> ===================================================================
> --- Python/mactoolboxglue.c   (revision 50522)
> +++ Python/mactoolboxglue.c   (working copy)
> @@ -60,8 +60,9 @@
>                       strncpy(buf, input, sizeof(buf) - 1);
>                       buf[sizeof(buf) - 1] = '\0';
>               }
> +             Py_DECREF(rv);
>       }
> -     
> +     Py_XDECREF(m);
>       return buf;
>  }
>  
> 
> I'm less sure about this one, but it looks like the DECREF
> is also required:

(Here's the patch that I *really* meant)

Index: Mac/Modules/macosmodule.c
===================================================================
--- Mac/Modules/macosmodule.c   (Revision 50515)
+++ Mac/Modules/macosmodule.c   (Arbeitskopie)
@@ -375,6 +375,7 @@
                                /* And try again... */
                                h = GetResource('Estr', err);
                        }
+                       Py_DECREF(m);
                }
        }
        /*

Thomas

_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com

Reply via email to