-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Nov 9, 2006, at 9:01 AM, A.M. Kuchling wrote:
> Should I backport this change to 2.5.1? Con: The patch adds two new > internal functions, _sync_flush() and _sync_close(), so it's an > internal API change. Pro: it's a patch that should reduce chances of > data loss, which is important to people processing mailboxes. > > Because it fixes a small chance of potential data loss and the new > functions are prefixed with _, my personal inclination would be to > backport this change. I agree. _ is a hint as to its non-publicness and I don't have a problem in principle adding such methods. In this particular case, it seems the patch improves reliability, so +1. - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iQCVAwUBRVNEL3EjvBPtnXfVAQIb0QP+Nmd6XPKQeeXaHrAG/fAFjrVHFn4SFkhH PtJqnLVOAQeSDonDdBQKluypGdWktcpGM/r1mz51cpJhxytYnAbwqeu1LyWJ/maX ABxG6zrkd7YCjZ5VyK2VQNs2dSLVWYYH24V/xwP5E5D2sEQ80sII3mnydSO+KLVI HBg9jztsc70= =Sj0Q -----END PGP SIGNATURE----- _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com