I think this is not the place to be discussing the patch (the tracker is), but while I think of it, I'll just say:
You need to DECREF the fn variable (both PyObject_GetAttrString<http://www.python.org/doc/api/object.html>and PyString_FromString <http://www.python.org/doc/api/stringObjects.html>return new references). If this makes no sense, read up on reference counting (http://docs.python.org/ext/refcounts.html, http://www.python.org/doc/api/countingRefs.html). .... + PyString_AsString(name), + PyString_AsString(fn)); + Py_DECREF(fn); } Also: - Do you really want "?" if you can't get the filename for some reason -- why not just not say anything? - Perhaps don't create a new variable "fn", use one of the many defined at the top of the eval function. Otherwise, looks like it will do the job. But I haven't tested it, just eyeballed it. Matt
_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
